Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hashing regression. #50655

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Conversation

oscardssmith
Copy link
Member

This fixes 2 bugs introduced by #49996 and #50041.
Closes #50628.

@oscardssmith oscardssmith added rationals The Rational type and values thereof bugfix This change fixes an existing bug hashing backport 1.10 Change should be backported to the 1.10 release labels Jul 24, 2023
base/float.jl Outdated Show resolved Hide resolved
base/float.jl Outdated Show resolved Hide resolved
base/float.jl Outdated Show resolved Hide resolved
oscardssmith and others added 2 commits July 24, 2023 11:43
Co-authored-by: Lilith Orion Hafner <[email protected]>
Co-authored-by: Lilith Orion Hafner <[email protected]>
base/float.jl Outdated Show resolved Hide resolved
Co-authored-by: Lilith Orion Hafner <[email protected]>
base/float.jl Outdated Show resolved Hide resolved
Co-authored-by: Lilith Orion Hafner <[email protected]>
@oscardssmith
Copy link
Member Author

Thanks @LilithHafner for the doc review. Good to get a second set of eyes on this.

Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality LGTM if tests pass.
Not sure what we were doing with right, it seems silly to me now.
Thanks for adding comments, too.

@oscardssmith
Copy link
Member Author

oscardssmith commented Jul 24, 2023

we should probably add tests for rational numbers that are subnormal floats and typemax float. I think there might actually be a bug for subnormals still

@oscardssmith
Copy link
Member Author

The subnormal cases work. I think this is good to merge.

@oscardssmith oscardssmith merged commit c777c71 into JuliaLang:master Jul 26, 2023
@oscardssmith oscardssmith deleted the fix-hashing branch July 26, 2023 10:21
@vtjnash
Copy link
Member

vtjnash commented Jul 27, 2023

Please try to make sure you are using squash-merge when appropriate. It is hard to backport messy commits like this, odd to see that you are adding typo's to the language according to the commit logs, and not great for bisecting.

@oscardssmith
Copy link
Member Author

hmm, I'm pretty sure I did squash and merge via GitHub.

KristofferC pushed a commit that referenced this pull request Aug 10, 2023
This fixes 2 bugs introduced by #49996 and #50041.
Closes #50628.

(cherry picked from commit c777c71)
@KristofferC
Copy link
Member

Also #50525 (comment).

KristofferC added a commit that referenced this pull request Aug 16, 2023
Backported PRs:
- [x] #50637 <!-- Remove SparseArrays legacy code -->
- [x] #50665 <!-- print `@time` msg into print buffer -->
- [x] #50523 <!-- Avoid generic call in most cases for getproperty -->
- [x] #50635 <!-- `versioninfo()`: include build info and unofficial
warning -->
- [x] #50670 <!-- Make reinterpret specialize fully. -->
- [x] #50666 <!-- include `--pkgimage=no` caches for stdlibs -->
- [x] #50765 
- [x] #50764
- [x] #50768
- [x] #50767
- [x] #50618 <!-- inference: continue const-prop' when concrete-eval
returns non-inlineable -->
- [x] #50689 <!-- Attach `tanpi` docstring to method -->
- [x] #50671 <!-- Fix rdiv of complex lhs by real factorizations -->
- [x] #50598 <!-- only limit types in stack traces in the REPL -->
- [x] #50766 <!-- Don't partition alwaysinline functions -->
- [x] #50771 <!-- re-allow non-string values in ENV `get!` -->
- [x] #50682 <!-- Add fallback if we have make a weird GC decision. -->
- [x] #50781 <!-- fix `bit_map!` with aliasing -->
- [x] #50172 <!-- print feature flags used for matching pkgimage -->
- [x] #50844 <!-- Bump OpenBLAS binaries to use the new GEMM
multithreading threshold -->
- [x] #50826 <!-- Update dependency builds -->
- [x] #50845 <!-- fix #50438, use default pool for at-threads -->
- [x] #50568 <!-- `Array(::AbstractRange)` should return an `Array` -->
- [x] #50655 <!-- fix hashing regression. -->
- [x] #50779 <!-- Minor refactor to image generation -->
- [x] #50791 <!-- Make symbols internal in jl_create_native, and only
externalize them when partitioning -->
- [x] #50724 <!-- Merge opaque closure modules with the rest of the
workqueue -->
- [x] #50738 <!-- Add alignment to constant globals -->
- [x] #50871 <!-- macOS: Don't inspect dead threadtls during exception
handling. -->

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:
- [ ] #50850 <!-- Remove weird Rational dispatch and add pi functions to
list -->
- [ ] #50823 <!-- Make ranges more robust with unsigned indexes. -->
- [ ] #50809 <!-- Limit type-printing in MethodError -->
- [ ] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [ ] #50594 <!-- Disallow non-index Integer types in isassigned -->
- [ ] #50385 <!-- Precompile pidlocks: add to NEWS and docs -->
- [ ] #49805 <!-- Limit TimeType subtraction to AbstractDateTime -->
@KristofferC KristofferC removed the backport 1.10 Change should be backported to the 1.10 release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug hashing rationals The Rational type and values thereof
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong hashes for some Rationals
5 participants